Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-release activities - Unused functions #642

Closed
averissimo opened this issue Feb 19, 2024 · 8 comments · Fixed by #659
Closed

Pre-release activities - Unused functions #642

averissimo opened this issue Feb 19, 2024 · 8 comments · Fixed by #659
Assignees
@chlebowa
Labels
core enhancement New feature or request

Comments

@averissimo
Copy link
Contributor

averissimo commented Feb 19, 2024 •
edited
Loading

Part of #624 related to vignettes. Please make a PR to pre-release@main.

  • Identify internal functions that are not used (if they exist)
  • Discuss case by case if they should be removed
@averissimo averissimo added bug Something isn't working core enhancement New feature or request and removed bug Something isn't working labels Feb 19, 2024
@averissimo averissimo mentioned this issue Feb 19, 2024
Closed
26 tasks
@chlebowa chlebowa self-assigned this Feb 21, 2024
@chlebowa chlebowa mentioned this issue Feb 21, 2024
Merged
@chlebowa chlebowa linked a pull request Feb 21, 2024 that will close this issue
642 unused functions #659
Merged
chlebowa added a commit that referenced this issue Feb 21, 2024
@chlebowa
642 unused functions (#659)
c57bc17 
Closes #642.

Removed `substitute_q` and `extract_input`.
Added `@keywords internal` to `is_num_var_short`.
@m7pr
Copy link
Contributor

m7pr commented Feb 22, 2024

@averissimo @chlebowa is this done? I see there was a PR closing this, but this didn't got closed. Do we expect any more action in here?

@chlebowa
Copy link
Contributor

Auto-close must have failed, as it often does.

@m7pr
Copy link
Contributor

m7pr commented Feb 22, 2024

I wonder if it depends on whether you write close issue_number and closeS issue_number

@m7pr
Copy link
Contributor

m7pr commented Feb 22, 2024 •
edited
Loading

It does not matter. closeS is supported https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

@m7pr
Copy link
Contributor

m7pr commented Feb 22, 2024

This states https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword that linking/closing works only for PR to the default (in our case main) branch.

#659 was pointing to the pre-release@main and that's not the default branch.

@chlebowa
Copy link
Contributor

My mistake then.

@averissimo
Copy link
Contributor Author

Oh cool! I didn't know that

@m7pr
Copy link
Contributor

m7pr commented Feb 22, 2024

it's no-ones mistake. that wasn't my point. now we know what is the logic : p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chlebowa chlebowa

Labels
core enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

642 unused functions insightsengineering/teal.modules.general
3 participants
@averissimo @chlebowa @m7pr