Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds min package version #229

Merged
merged 7 commits into from
Apr 9, 2024
Merged

Adds min package version #229

merged 7 commits into from
Apr 9, 2024

Conversation

averissimo
Copy link
Contributor

@averissimo averissimo commented Jul 26, 2023

WIP :: parent issue: insightsengineering/nestdevs-tasks#7

Supersede:

🔴 What's needed before merging?

This PR depends on some upstream changes that need to be finalized/merged before being ready to review.

Change in code

  • verdepcheck.yml action (see comments)
    • Remove on: push section
    • Change branch to main

PRS

Changes description

  • Adds minimum version for packages DESCRIPTION
  • Adds Config/Need/verdepcheck section in DESCRIPTION
  • Updates verdepcheck action

@averissimo
Copy link
Contributor Author

averissimo commented Dec 18, 2023

Blocked until {teal.slice} is released in CRAN as they are secondary depedencies from {teal} that {verdepcheck} cannot find otherwise

@pawelru
Copy link
Contributor

pawelru commented Apr 9, 2024

ok this is ready to be merged in. We have only one failure on the release strategy which is expected since we require development version of packages

@pawelru pawelru marked this pull request as ready for review April 9, 2024 11:04
@pawelru pawelru enabled auto-merge (squash) April 9, 2024 11:06
Copy link
Contributor

github-actions bot commented Apr 9, 2024

badge

Code Coverage Summary

Filename                                 Stmts    Miss  Cover    Missing
-------------------------------------  -------  ------  -------  ---------
R/tm_g_gh_boxplot.R                        359     359  0.00%    175-602
R/tm_g_gh_correlationplot.R                570     570  0.00%    227-905
R/tm_g_gh_density_distribution_plot.R      285     285  0.00%    135-471
R/tm_g_gh_lineplot.R                       555     555  0.00%    159-799
R/tm_g_gh_scatterplot.R                    252     252  0.00%    144-449
R/tm_g_gh_spaghettiplot.R                  304     304  0.00%    192-564
R/toggleable_slider.R                      154     154  0.00%    72-243
R/utils-arbitrary_lines.r                  125     125  0.00%    19-175
R/utils-data_constraints.r                 190     190  0.00%    2-257
R/utils-keep_range_slider_updated.r         23      23  0.00%    8-38
R/utils-maptrt.r                             9       9  0.00%    24-36
R/utils-templ_ui.r                          48      48  0.00%    2-73
R/utils.R                                   39      39  0.00%    12-83
R/zzz.R                                      2       2  0.00%    2-3
TOTAL                                     2915    2915  0.00%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 2aaf616

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@pawelru pawelru merged commit 93e42e9 into main Apr 9, 2024
46 checks passed
@pawelru pawelru deleted the verdepcheck_action branch April 9, 2024 11:09
@pawelru pawelru removed the blocked label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants