Skip to content

Commit

Permalink
Adds min package version (#229)
Browse files Browse the repository at this point in the history
WIP :: parent issue:
insightsengineering/nestdevs-tasks#7

Supersede:
* #218

### 🔴 What's needed before merging?

This PR depends on some upstream changes that need to be
finalized/merged before being ready to review.

#### Change in code

* `verdepcheck.yml` action (see comments)
  - [x] Remove `on: push` section 
  - [x] Change branch to main

#### PRS

- [x] verdepcheck
  * insightsengineering/verdepcheck#24
  * insightsengineering/verdepcheck#26
- [x] verdepcheck-action
  * insightsengineering/r-verdepcheck-action#16

### Changes description

* Adds minimum version for packages `DESCRIPTION`
* Adds `Config/Need/verdepcheck` section in `DESCRIPTION`
* Updates verdepcheck action

---------

Signed-off-by: Pawel Rucki <[email protected]>
Co-authored-by: Pawel Rucki <[email protected]>
  • Loading branch information
averissimo and pawelru authored Apr 9, 2024
1 parent a0af1cd commit 93e42e9
Show file tree
Hide file tree
Showing 3 changed files with 44 additions and 14 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/scheduled.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false
matrix:
test-strategy: ["min", "release", "max"]
test-strategy: ["min_cohort", "min_isolated", "release", "max"]
uses: insightsengineering/r.pkg.template/.github/workflows/verdepcheck.yaml@main
name: Dependency Test - ${{ matrix.test-strategy }} 🔢
secrets:
Expand Down
52 changes: 39 additions & 13 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -29,40 +29,66 @@ URL: https://insightsengineering.github.io/teal.goshawk/,
https://github.com/insightsengineering/teal.goshawk/
BugReports: https://github.com/insightsengineering/teal.goshawk/issues
Depends:
goshawk (>= 0.1.15),
goshawk (>= 0.1.15.9007),
R (>= 3.6),
shiny,
shiny (>= 1.6.0),
teal (>= 0.14.0.9027),
teal.transform (>= 0.4.0.9011)
Imports:
checkmate,
checkmate (>= 2.1.0),
colourpicker,
dplyr,
DT,
ggplot2,
dplyr (>= 1.0.5),
DT (>= 0.13),
ggplot2 (>= 3.4.0),
grDevices,
lifecycle,
lifecycle (>= 0.2.0),
methods,
rlang,
rlang (>= 1.0.0),
shinyjs,
shinyvalidate,
stats,
teal.code (>= 0.4.1.9009),
teal.logger (>= 0.1.3.9013),
teal.reporter (>= 0.2.0),
teal.widgets (>= 0.4.0),
tidyr
tidyr (>= 0.8.3)
Suggests:
knitr,
knitr (>= 1.42),
nestcolor (>= 0.1.0),
rmarkdown,
stringr,
rmarkdown (>= 2.19),
stringr (>= 1.4.1),
teal.data (>= 0.3.0.9018),
tern (>= 0.7.10),
testthat (>= 2.0),
testthat (>= 3.0.4),
utils
VignetteBuilder:
knitr
Config/Needs/verdepcheck:
insightsengineering/goshawk,
rstudio/shiny,
insightsengineering/teal,
insightsengineering/teal.transform,
mllg/checkmate,
daattali/colourpicker,
tidyverse/dplyr,
rstudio/DT,
tidyverse/ggplot2,
r-lib/lifecycle,
r-lib/rlang,
daattali/shinyjs,
rstudio/shinyvalidate,
insightsengineering/teal.code,
insightsengineering/teal.logger,
insightsengineering/teal.reporter,
insightsengineering/teal.widgets,
tidyverse/tidyr,
yihui/knitr,
insightsengineering/nestcolor,
rstudio/rmarkdown,
tidyverse/stringr,
insightsengineering/teal.data,
insightsengineering/tern,
r-lib/testthat
Config/Needs/website: insightsengineering/nesttemplate
Encoding: UTF-8
Language: en-US
Expand Down
4 changes: 4 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@

* Updated the documentation and vignettes to demonstrate method to pass `teal_data` object to `teal::init()`.

### Miscellaneous

* Specified minimal version of package dependencies.

# teal.goshawk 0.1.15

### Enhancements
Expand Down

0 comments on commit 93e42e9

Please sign in to comment.