Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow more control on the sas configuration #45

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,4 @@ Encoding: UTF-8
Language: en-US
LazyData: true
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.2.3
RoxygenNote: 7.3.1
3 changes: 3 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# sasr 0.1.2.9006

* Update `sas_session` to allow finer control over the sas session.
* The argument `sascfg` has been replaced by `cfgfile` in `sas_session`.

# sasr 0.1.2

* First CRAN version of the package.
Expand Down
8 changes: 5 additions & 3 deletions R/utils.R
Original file line number Diff line number Diff line change
Expand Up @@ -120,13 +120,15 @@ get_sas_session <- function() {
#' @description `r lifecycle::badge("experimental")`
#' Create a SAS session.
#'
#' @param sascfg (`character`)\cr SAS session configuration.
#' @param cfgfile (`string`)\cr SAS session configuration.
#' @param ... additional arguments passed to `saspy.SASsession()`.
#' Can override the configuration file.
#'
#' @return SAS session.
#' @export
sas_session <- function(sascfg = get_sas_cfg()) {
sas_session <- function(cfgfile = get_sas_cfg(), ...) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also needs to be renamed in sas_session_ssh() below

validate_sascfg(sascfg)
session <- saspy$SASsession(cfgfile = sascfg)
session <- saspy$SASsession(cfgfile = sascfg, ...)
.sasr_env$.sas_session <- session
return(session)
}
Expand Down
7 changes: 5 additions & 2 deletions man/sas_session.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions man/sas_session_ssh.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion man/sasr-package.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading