Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow more control on the sas configuration #45

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

allow more control on the sas configuration #45

wants to merge 1 commit into from

Conversation

clarkliming
Copy link
Collaborator

close #44

allow more arguments and modify the argument name

@github-actions GitHub Actions
Copy link
Contributor

badge

Code Coverage Summary

Filename       Stmts    Miss  Cover    Missing
-----------  -------  ------  -------  ------------
R/run_sas.R        6       0  100.00%
R/sascfg.R         8       8  0.00%    26-33
R/utils.R         66       7  89.39%   140-145, 166
R/zzz.R            2       2  0.00%    15-16
TOTAL             82      17  79.27%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: a6fab40

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions GitHub Actions
Copy link
Contributor

Unit Tests Summary

 1 files   4 suites   0s ⏱️
15 tests 11 ✅ 4 💤 0 ❌
20 runs  15 ✅ 5 💤 0 ❌

Results for commit a6fab40.

danielinteractive
danielinteractive reviewed Apr 29, 2024
View reviewed changes
R/utils.R
#'
#' @return SAS session.
#' @export
sas_session <- function(sascfg = get_sas_cfg()) {
sas_session <- function(cfgfile = get_sas_cfg(), ...) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also needs to be renamed in sas_session_ssh() below

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielinteractive danielinteractive danielinteractive approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allow more arguments on session creation
2 participants
@clarkliming @danielinteractive