Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK-3357: Add node 22 to matrix and set as default #220

Merged
merged 3 commits into from
Aug 16, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
matrix:
# We test against different OSes, because the build toolchain has OS-specific dependencies.
os: ["ubuntu-latest", "windows-latest", "macos-latest"]
node-version: ["20.x", "18.x"]
node-version: ["22.x", "20.x", "18.x"]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
Expand All @@ -30,7 +30,7 @@ jobs:
- run: npm run test
# Upload coverage for sonarcube (only matching OS and one node version required)
- uses: actions/upload-artifact@v4
if: ${{ matrix.node-version == '20.x' }}
if: ${{ matrix.node-version == '22.x' }}
with:
name: code-coverage-${{ matrix.os }}-${{matrix.node-version}}
path: coverage/
Expand All @@ -47,7 +47,7 @@ jobs:
fetch-depth: 0
- uses: actions/download-artifact@v4
with:
name: code-coverage-ubuntu-latest-20.x
name: code-coverage-ubuntu-latest-22.x
path: coverage/
- uses: SonarSource/sonarcloud-github-action@v2
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e-node.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
node-version: ["20.x", "18.x"]
node-version: ["22.x", "20.x", "18.x"]
# PodSpaces doesn't support error descriptions yet.
environment-name: ["ESS Dev-2-3"]
experimental: [false]
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
20
22
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@ and `String.prototype.endsWith`.

## Node.js Support

Our JavaScript Client Libraries track Node.js [LTS
releases](https://nodejs.org/en/about/releases/), and support 18.x and 20.x.
See [Inrupt’s Javascript Client libraries documentation](https://docs.inrupt.com/developer-tools/javascript/client-libraries/#node-js-support).

# Installation

Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@
"@inrupt/internal-test-env": "^3.2.1",
"@inrupt/jest-jsdom-polyfills": "^3.2.1",
"@inrupt/solid-client-authn-node": "^2.2.4",
"@playwright/test": "^1.46.0",
"@typescript-eslint/eslint-plugin": "^7.17.0",
"@typhonjs-typedoc/ts-lib-docs": "^2023.7.12",
"@playwright/test": "^1.46.0",
"dotenv": "^16.4.5",
"eslint": "^8.57.0",
"eslint-config-next": "^14.2.5",
Expand All @@ -70,6 +70,6 @@
"typescript": "^5.5.4"
},
"engines": {
"node": "^18.0.0 || ^20.0.0"
"node": "^18.0.0 || ^20.0.0 || ^22.0.0"
}
}
2 changes: 1 addition & 1 deletion rollup.config.mjs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import pkg from "./package.json" assert { type: "json" };
import pkg from "./package.json" with { type: "json" };
import sharedConfig from "@inrupt/base-rollup-config";

const config = sharedConfig(pkg);
Expand Down