-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK-3357: Add node 22 to matrix and set as default #220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The .nvmrc file hasn't been updated
README.md
Outdated
@@ -36,7 +36,7 @@ and `String.prototype.endsWith`. | |||
## Node.js Support | |||
|
|||
Our JavaScript Client Libraries track Node.js [LTS | |||
releases](https://nodejs.org/en/about/releases/), and support 18.x and 20.x. | |||
releases](https://nodejs.org/en/about/releases/), and support 18.x, 20.x, and 22.x. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you replace this section with a link to our documentation instead, so that we don't have duplicate information, most times one of which is outdated?
I think it was - it is in the PR |
🤦 my bad, apparently 5 is my max limit on files changed I can track |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good. Technically, our JS docs is behind the actual truth (this change brings support to the current NodeJS version in addition to the active LTS and Maintenance LTS), but I'd rather keep a unique record of what we commit to, and stick to that commitment, rather than being delinquent on that commitment if we don't jump on the latest NodeJS version right away. The content of the package.json
engines
field indicates actual support if users want to get ahead of our documented policy.
New feature description
Added support for Node 22.