Add rollup to dev dependencies

.github/workflows/e2e-browser.yml

@@ -1,6 +1,8 @@
 name: End-to-end browser tests
 
-on: [push]
+on:
+  push:
+  workflow_dispatch:
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: true

.github/workflows/e2e-node.yml

@@ -2,6 +2,7 @@ name: End-to-end node tests
 
 on:
   push:
+  workflow_dispatch:
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: true

e2e/node/server/e2e-browser-script.spec.ts

@@ -26,7 +26,7 @@ import {
 import { afterAll, beforeAll, describe, expect, it, jest } from "@jest/globals";
 import type { Request } from "@playwright/test";
 import { firefox } from "@playwright/test";
-import type { ILogoutOptions } from "core";
+import type { ILogoutOptions } from "@inrupt/solid-client-authn-core";
 import { custom } from "openid-client";
 // Here we want to test how the local code behaves, not the already published one.
 // eslint-disable-next-line import/no-relative-packages

e2e/node/server/express.ts

@@ -40,18 +40,19 @@ export function createApp(
   // Initialised when the server comes up and is running...
   let session: Session;
 
-  app.get("/", async (req, res) => {
-    return res.status(200).end();
+  app.get("/", (_req, res) => {
+    res.status(200).end();
   });
 
   app.get("/login", async (req, res) => {
     const { oidcIssuer, clientId } = req.query;
 
     if (typeof oidcIssuer !== "string") {
-      return res.status(400).send("oidcIssuer is required").end();
+      res.status(400).send("oidcIssuer is required").end();
+      return;
     }
 
-    return session.login({
+    await session.login({
       redirectUrl: `http://localhost:${CONSTANTS.CLIENT_AUTHN_TEST_PORT}/redirect`,
       oidcIssuer,
       clientId: typeof clientId === "string" ? clientId : undefined,
@@ -65,24 +66,23 @@ export function createApp(
     );
 
     if (info?.isLoggedIn) {
-      return res.redirect("/");
+      res.redirect("/");
+      return;
     }
 
-    return res.status(400).send("could not log in").end();
+    res.status(400).send("could not log in").end();
   });
 
   app.get("/fetch", async (req, res) => {
     const { resource } = req.query;
 
     if (typeof resource !== "string") {
-      return res
-        .status(400)
-        .send("resource must be provided as a string")
-        .end();
+      res.status(400).send("resource must be provided as a string").end();
+      return;
     }
 
     const response = await session.fetch(resource);
-    return res
+    res
       .status(response.status)
       .send(await response.text())
       .end();
@@ -91,27 +91,27 @@ export function createApp(
   app.get("/logout", async (_req, res) => {
     try {
       await session.logout();
-      return res.status(200).send("successful logout").end();
+      res.status(200).send("successful logout").end();
     } catch (error) {
-      return res.status(400).send(`Logout processing failed: [${error}]`).end();
+      res.status(400).send(`Logout processing failed: [${error}]`).end();
     }
   });
 
   app.get("/postLogoutUrl", async (_req, res) => {
-    return res.status(200).send("successfully at post logout").end();
+    res.status(200).send("successfully at post logout").end();
   });
 
   app.get("/idplogout", async (_req, res) => {
     try {
-      return await session.logout({
+      await session.logout({
         logoutType: "idp",
         postLogoutUrl: `http://localhost:${CONSTANTS.CLIENT_AUTHN_TEST_PORT}/postLogoutUrl`,
         handleRedirect: (url) => {
           res.redirect(url);
         },
       });
     } catch (error) {
-      return res.status(400).send(`Logout processing failed: [${error}]`).end();
+      res.status(400).send(`Logout processing failed: [${error}]`).end();
     }
   });