Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rollup to dev dependencies #3699

Merged
merged 14 commits into from
Sep 30, 2024
Merged

Add rollup to dev dependencies #3699

merged 14 commits into from
Sep 30, 2024

Conversation

NSeydoux
Copy link
Contributor

Supersedes #3695 to make rollup a direct dev dependency.

@NSeydoux NSeydoux requested a review from a team as a code owner September 26, 2024 08:36
edwardsph
edwardsph approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@edwardsph edwardsph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NSeydoux NSeydoux enabled auto-merge (squash) September 26, 2024 08:42
NSeydoux
NSeydoux commented Sep 30, 2024
View reviewed changes
e2e/node/server/express.ts
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out we were not using express quite correctly, and that had never upset TS until now.

@NSeydoux NSeydoux merged commit ba2d7bc into main Sep 30, 2024
34 checks passed
@NSeydoux NSeydoux deleted the chore/upgrade-rollup branch September 30, 2024 11:59
@NSeydoux NSeydoux mentioned this pull request Sep 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardsph edwardsph edwardsph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NSeydoux @edwardsph