Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(extension): add missing ros tooltip for stake pools table #915

Merged
merged 2 commits into from
Feb 27, 2024
Merged

feat(extension): add missing ros tooltip for stake pools table #915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ebf507
feat(extension): add missing ros tooltip for stake pools table
vetalcore Feb 23, 2024
38611ff
fix(extension): resolve sdet comments
vetalcore Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/browser-extension-wallet/src/lib/translations/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1090,9 +1090,9 @@
"title": "Cost",
"tooltip": "The cost is not directly paid by the delegator; they are deducted from a pool's rewards, consisting of a fixed cost and a variable cost, which fund the pool's operational costs"
},
"ros": {
"apy": {
"title": "ROS",
"tooltip": "Estimated 'Return On Stake' based on previous pool performance"
"tooltip": "An estimation of the potential rewards you will earn per epoch if you delegate the intended amount of stake. The system looks at the pool's parameters and historical performance data to calculate potential rewards, assuming that the pool reaches optimal saturation."
},
"saturation": {
"title": "Saturation",
Expand Down
4 changes: 2 additions & 2 deletions ...et/src/views/browser-view/features/staking/components/StakePoolsTable/StakePoolsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export const StakePoolsTable = ({ scrollableTargetId }: stakePoolsTableProps): R

const tableHeaderTranslations: TranslationsFor<MetricType> = {
ticker: t('cardano.stakePoolTableBrowser.tableHeader.ticker.title'),
apy: t('cardano.stakePoolTableBrowser.tableHeader.ros.title'),
apy: t('cardano.stakePoolTableBrowser.tableHeader.apy.title'),
cost: t('cardano.stakePoolTableBrowser.tableHeader.cost.title'),
saturation: t('cardano.stakePoolTableBrowser.tableHeader.saturation.title'),
margin: t('cardano.stakePoolTableBrowser.tableHeader.margin.title'),
Expand All @@ -73,7 +73,7 @@ export const StakePoolsTable = ({ scrollableTargetId }: stakePoolsTableProps): R
};
const tableHeaderTooltipsTranslations: TranslationsFor<MetricType> = {
ticker: t('cardano.stakePoolTableBrowser.tableHeader.ticker.tooltip'),
apy: t('cardano.stakePoolTableBrowser.tableHeader.ros.tooltip'),
apy: t('cardano.stakePoolTableBrowser.tableHeader.apy.tooltip'),
cost: t('cardano.stakePoolTableBrowser.tableHeader.cost.tooltip'),
saturation: t('cardano.stakePoolTableBrowser.tableHeader.saturation.tooltip'),
margin: t('cardano.stakePoolTableBrowser.tableHeader.margin.tooltip'),
Expand Down
2 changes: 1 addition & 1 deletion packages/staking/src/features/BrowsePools/BrowsePools.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export const BrowsePools = () => {
const fetchingPools = walletStoreStakePoolSearchResultsStatus === StateStatus.LOADING;

const tableHeaderTranslations = {
apy: t('browsePools.stakePoolTableBrowser.tableHeader.ros.title'),
apy: t('browsePools.stakePoolTableBrowser.tableHeader.apy.title'),
blocks: t('browsePools.stakePoolTableBrowser.tableHeader.blocks.title'),
cost: t('browsePools.stakePoolTableBrowser.tableHeader.cost.title'),
liveStake: t('browsePools.stakePoolTableBrowser.tableHeader.liveStake.title'),
Expand Down
2 changes: 1 addition & 1 deletion packages/staking/src/features/DelegationCard/DelegationTooltip.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export const DelegationTooltip = ({
description={
<Box w="$148">
<Flex justifyContent="space-between">
<Box>{t('browsePools.stakePoolTableBrowser.tableHeader.ros.title')}</Box>
<Box>{t('browsePools.stakePoolTableBrowser.tableHeader.apy.title')}</Box>
<Box>{apy ? `${apy}%` : '-'}</Box>
</Flex>
<Flex justifyContent="space-between">
Expand Down
6 changes: 3 additions & 3 deletions packages/staking/src/features/i18n/translations/en.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ export const en: Translations = {
'browsePools.stakePoolTableBrowser.sortByTitle.saturation': 'Saturation',
'browsePools.stakePoolTableBrowser.sortByTitle.ticker': 'Ticker name',
'browsePools.stakePoolTableBrowser.stake': 'Stake',
'browsePools.stakePoolTableBrowser.tableHeader.apy.title': 'ROS',
'browsePools.stakePoolTableBrowser.tableHeader.apy.tooltip':
"An estimation of the potential rewards you will earn per epoch if you delegate the intended amount of stake. The system looks at the pool's parameters and historical performance data to calculate potential rewards, assuming that the pool reaches optimal saturation.",
'browsePools.stakePoolTableBrowser.tableHeader.blocks.title': 'Blocks',
'browsePools.stakePoolTableBrowser.tableHeader.blocks.tooltip': 'Total blocks created by the pool.',
'browsePools.stakePoolTableBrowser.tableHeader.cost.title': 'Cost',
Expand All @@ -49,9 +52,6 @@ export const en: Translations = {
'browsePools.stakePoolTableBrowser.tableHeader.pledge.title': 'Pledge',
'browsePools.stakePoolTableBrowser.tableHeader.pledge.tooltip':
'An amount of self‐bonded assets intended to remain staked to the pool for as long as it operates',
'browsePools.stakePoolTableBrowser.tableHeader.ros.title': 'ROS',
'browsePools.stakePoolTableBrowser.tableHeader.ros.tooltip':
"Estimated 'Return On Stake' based on previous pool performance",
'browsePools.stakePoolTableBrowser.tableHeader.saturation.title': 'Saturation',
'browsePools.stakePoolTableBrowser.tableHeader.saturation.tooltip':
'Once a pool reaches the point of saturation, it will offer diminishing rewards',
Expand Down
2 changes: 1 addition & 1 deletion packages/staking/src/features/i18n/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ type KeysStructure = {
title: '';
tooltip: '';
};
ros: {
apy: {
title: '';
tooltip: '';
};
Expand Down
Loading