Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(extension): add missing ros tooltip for stake pools table #915

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

vetalcore
Copy link
Contributor

@vetalcore vetalcore commented Feb 23, 2024

Checklist

  • JIRA - LW-9827
  • Proper tests implemented
  • Screenshots added.

Proposed solution

Update translations.

Testing

enable USE_ROS_STAKING_COLUMN feature toggle, hove over ROS column to see the updated tooltip.

Screenshots

Screenshot 2024-02-27 at 14 06 39

@vetalcore vetalcore self-assigned this Feb 23, 2024
@vetalcore vetalcore requested a review from a team as a code owner February 23, 2024 11:54
@github-actions github-actions bot added browser Changes to the browser application. staking Changes to the staking package. labels Feb 23, 2024
Copy link

github-actions bot commented Feb 23, 2024

Allure report

allure-report-publisher generated test report!

smokeTests: ✅ test report for 38611ff4

passed failed skipped flaky total result
Total 32 0 0 0 32

@coveralls
Copy link

coveralls commented Feb 23, 2024

Coverage Status

Changes unknown
when pulling 38611ff on feat/LW-9827-add-ros-tooltip-for-stake-pools-table
into ** on main**.

Copy link

sonarcloud bot commented Feb 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
30.0% Duplication on New Code

See analysis details on SonarCloud

@vetalcore vetalcore merged commit ba5fbf5 into main Feb 27, 2024
10 of 11 checks passed
@vetalcore vetalcore deleted the feat/LW-9827-add-ros-tooltip-for-stake-pools-table branch February 27, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser Changes to the browser application. staking Changes to the staking package.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants