Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extension): reload app on ledger disconnect during onboarding #913

Merged
merged 1 commit into from
Feb 27, 2024
Merged

fix(extension): reload app on ledger disconnect during onboarding #913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...ion-wallet/src/views/browser-view/features/wallet-setup/components/HardwareWalletFlow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,8 @@ export const HardwareWalletFlow = ({
const onRetry = () => {
setIsErrorDialogVisible(false);
goBackToConnect();
// TODO: Remove this workaround with full app reload when SDK allows to connect Hardware Wallet for the 2nd time.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a ticket exists for this can we link/create it

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mchappell What about disconnecting? I have this on a open PR and solved the issue I was having.

onAppReload();
};

const handleStartOver = () => {
Expand Down
1 change: 1 addition & 0 deletions packages/core/src/ui/components/WalletSetup/WalletSetupWalletNameStep.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ export const WalletSetupWalletNameStep = ({
label={translations.walletName}
value={walletName}
onChange={handleNameChange}
autoFocus
/>
{isDirty && walletName && !isNameValid && (
<p className={styles.formError} data-testid="wallet-setup-register-name-error">
Expand Down
Loading