fix(extension): reload app on ledger disconnect during onboarding #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Changes unknown |
Allure report
smokeTests: ✅ test report for bcbf694d
|
przemyslaw-wlodek
approved these changes
Feb 26, 2024
mchappell
reviewed
Feb 26, 2024
| @@ -307,6 +307,8 @@ export const HardwareWalletFlow = ({ | |||
| const onRetry = () => { | |||
| setIsErrorDialogVisible(false); | |||
| goBackToConnect(); | |||
| // TODO: Remove this workaround with full app reload when SDK allows to connect Hardware Wallet for the 2nd time. | |||
There was a problem hiding this comment.
If a ticket exists for this can we link/create it
There was a problem hiding this comment.
@mchappell What about disconnecting? I have this on a open PR and solved the issue I was having.
mchappell
approved these changes
Feb 26, 2024
wklos-iohk
approved these changes
Feb 27, 2024
vetalcore
deleted the
fix/LW-8720-handle-ledger-disconnect-during-onboarding
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
Use workaround with full app reload when SDK allows to connect Hardware Wallet for the 2nd time.
Testing
Follow steps described in the ticket
Screenshots
Attach screenshots here if implementation involves some UI changes