Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cleanup hd-discovery analytics event for forgot password flow #1096

Merged
merged 4 commits into from
May 1, 2024
Merged

fix: cleanup hd-discovery analytics event for forgot password flow #1096

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
90a3907
fix: cleanup hd-discovery analytics event for forgot password flow
greatertomi Apr 23, 2024
7d1f49c
fix: enable unlock wallet button for testing
greatertomi Apr 29, 2024
d4c95d8
fix: disable unlock wallet button
greatertomi Apr 30, 2024
64ddef6
Merge branch 'main' into fix/lw-10344-cleanup-analytics-event
szymonmaslowski May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 3 additions & 29 deletions ...sion-wallet/src/views/browser-view/features/wallet-setup/components/WalletSetupWizard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import React, { Suspense, useCallback, useEffect, useState } from 'react';
import { Trans, useTranslation } from 'react-i18next';
import { wordlists } from 'bip39';
import { useLocalStorage, useTimeSpentOnPage, useWalletManager } from '@hooks';
import { useTimeSpentOnPage, useWalletManager } from '@hooks';
import {
MnemonicStage,
MnemonicVideoPopupContent,
Expand All @@ -13,20 +13,14 @@ import {
import { Wallet } from '@lace/cardano';
import { WalletSetupLayout } from '@src/views/browser-view/components/Layout';
import { WarningModal } from '@src/views/browser-view/components/WarningModal';
import {
EnhancedAnalyticsOptInStatus,
PostHogAction,
postHogOnboardingActions
} from '@providers/AnalyticsProvider/analyticsTracker';
import { PostHogAction, postHogOnboardingActions } from '@providers/AnalyticsProvider/analyticsTracker';
import { config } from '@src/config';
import { Fallback } from './Fallback';
import { deleteFromLocalStorage } from '@src/utils/local-storage';
import { useAnalyticsContext } from '@providers';
import { ENHANCED_ANALYTICS_OPT_IN_STATUS_LS_KEY } from '@providers/AnalyticsProvider/config';
import * as process from 'process';
import { SendOnboardingAnalyticsEvent, SetupType } from '../types';
import { isScriptAddress } from '@cardano-sdk/wallet';
import { filter, firstValueFrom } from 'rxjs';
import { getWalletFromStorage } from '@src/utils/get-wallet-from-storage';
import { toast } from '@lace/common';
import Copy from '@src/assets/icons/copy.component.svg';
Expand Down Expand Up @@ -71,7 +65,6 @@ export const WalletSetupWizard = ({
initialStep = WalletSetupSteps.Register
}: WalletSetupWizardProps): React.ReactElement => {
const [currentStep, setCurrentStep] = useState<WalletSetupSteps>(initialStep);
const [walletInstance, setWalletInstance] = useState<Wallet.CardanoWallet | undefined>();
const [mnemonicLength, setMnemonicLength] = useState<number>(DEFAULT_MNEMONIC_LENGTH);
const [mnemonic, setMnemonic] = useState<string[]>([]);
const [currentSetupMnemonicStage, setCurrentSetupMnemonicStage] = useState<MnemonicStage>('writedown');
Expand All @@ -80,10 +73,6 @@ export const WalletSetupWizard = ({
const { createWallet } = useWalletManager();
const analytics = useAnalyticsContext();
const { t } = useTranslation();
const [enhancedAnalyticsStatus] = useLocalStorage(
ENHANCED_ANALYTICS_OPT_IN_STATUS_LS_KEY,
EnhancedAnalyticsOptInStatus.OptedOut
);

const { updateEnteredAtTime } = useTimeSpentOnPage();

Expand Down Expand Up @@ -184,19 +173,6 @@ export const WalletSetupWizard = ({
}
};

const goToMyWallet = useCallback(
async (cardanoWallet: Wallet.CardanoWallet = walletInstance) => {
if (enhancedAnalyticsStatus === EnhancedAnalyticsOptInStatus.OptedIn) {
const addresses = await firstValueFrom(cardanoWallet?.wallet?.addresses$.pipe(filter((a) => a.length > 0)));
const hdWalletDiscovered = addresses.some((addr) => !isScriptAddress(addr) && addr.index > 0);
if (hdWalletDiscovered) {
void analytics.sendEventToPostHog(PostHogAction.OnboardingRestoreHdWallet);
}
}
},
[analytics, enhancedAnalyticsStatus, walletInstance]
);

const moveForward = useCallback(() => {
const nextStep = walletSetupWizard[currentStep].next;
setCurrentStep(nextStep);
Expand All @@ -211,7 +187,6 @@ export const WalletSetupWizard = ({
password,
chainId: DEFAULT_CHAIN_ID
});
setWalletInstance(wallet);

wallet.wallet.addresses$.subscribe((addresses) => {
if (addresses.length === 0) return;
Expand All @@ -223,7 +198,6 @@ export const WalletSetupWizard = ({

if (setupType === SetupType.FORGOT_PASSWORD) {
deleteFromLocalStorage('isForgotPasswordFlow');
void goToMyWallet(wallet);
} else {
moveForward();
}
Expand All @@ -232,7 +206,7 @@ export const WalletSetupWizard = ({
throw new Error(error);
}
},
[createWallet, mnemonic, analytics, setupType, goToMyWallet, moveForward]
[createWallet, mnemonic, analytics, setupType, moveForward]
);

const handleSubmit = async (result: { password: string; walletName: string }) => {
Expand Down