Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cleanup hd-discovery analytics event for forgot password flow #1096

Merged
merged 4 commits into from
May 1, 2024

Conversation

greatertomi
Copy link
Contributor

Checklist

  • JIRA - LW-10344
  • Proper tests implemented
  • Screenshots added.

Proposed solution

cleanup hd-discovery analytics event for forgot password flow

Testing

Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met

Screenshots

Attach screenshots here if implementation involves some UI changes

@greatertomi greatertomi requested a review from a team as a code owner April 23, 2024 16:25
Copy link

github-actions bot commented Apr 29, 2024

Allure report

allure-report-publisher generated test report!

smokeTests: ❌ test report for 64ddef69

passed failed skipped flaky total result
Total 29 1 0 0 30

Copy link
Contributor

@emiride emiride left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this with lock button enabled and there are no more extra posthog events being sent.

@greatertomi greatertomi force-pushed the fix/lw-10344-cleanup-analytics-event branch from 8b2baa0 to ac010c0 Compare April 30, 2024 11:15
@szymonmaslowski szymonmaslowski force-pushed the fix/lw-10344-cleanup-analytics-event branch from 228acd7 to 64ddef6 Compare May 1, 2024 07:52
@szymonmaslowski szymonmaslowski enabled auto-merge (squash) May 1, 2024 07:53
Copy link

sonarcloud bot commented May 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@szymonmaslowski szymonmaslowski merged commit bec0c4b into main May 1, 2024
9 checks passed
@szymonmaslowski szymonmaslowski deleted the fix/lw-10344-cleanup-analytics-event branch May 1, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants