Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(inputs.modbus): Add device or controller information to error messages #16114

Merged
merged 1 commit into from
Nov 4, 2024
Merged

chore(inputs.modbus): Add device or controller information to error messages #16114

merged 1 commit into from
Nov 4, 2024

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Oct 30, 2024

Summary

Add the configured device name or controller to error messages to identify the related plugin instances if multiple modbus plugins are used.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #16112

@telegraf-tiger telegraf-tiger bot added area/modbus chore plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Oct 30, 2024
@srebhan srebhan mentioned this pull request Oct 30, 2024
Closed
@srebhan srebhan self-assigned this Oct 30, 2024
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@SoeNorKle SoeNorKle mentioned this pull request Oct 31, 2024
Closed
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Nov 4, 2024
@srebhan srebhan assigned DStrand1 and unassigned srebhan Nov 4, 2024
@DStrand1 DStrand1 merged commit 85f025a into influxdata:master Nov 4, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.32.3 milestone Nov 4, 2024
s-r-engineer pushed a commit to s-r-engineer/telegraf that referenced this pull request Nov 11, 2024
@srebhan @s-r-engineer
chore(inputs.modbus): Add device or controller information to error m…
6e4a769 
…essages (influxdata#16114)
srebhan added a commit that referenced this pull request Nov 18, 2024
@srebhan
chore(inputs.modbus): Add device or controller information to error m…
97ca8d9 
…essages (#16114)

(cherry picked from commit 85f025a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DStrand1 DStrand1 DStrand1 approved these changes

Assignees

@DStrand1 DStrand1

Labels
area/modbus chore plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.32.3
Development

Successfully merging this pull request may close these issues.

feat(inputs.modbus) See Hosts on Errormessages
2 participants
@srebhan @DStrand1