Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.modbus) See Hosts on Errormessages #16112

Closed
SoeNorKle opened this issue Oct 30, 2024 · 2 comments · Fixed by #16114
Closed

feat(inputs.modbus) See Hosts on Errormessages #16112

SoeNorKle opened this issue Oct 30, 2024 · 2 comments · Fixed by #16114
Assignees
Labels
feature request Requests for new plugin and for new features to existing plugins

Comments

@SoeNorKle
Copy link

Use Case

To get a meaningful errormessage I have to see which host generated an error on a modbus request.

Expected behavior

Print the hostname if a request fails

Actual behavior

Only print the slaveID in the error message

Additional info

No response

@SoeNorKle SoeNorKle added the feature request Requests for new plugin and for new features to existing plugins label Oct 30, 2024
@SoeNorKle SoeNorKle changed the title Modbus Plugin - See Hosts on Errormessages feat(inputs.modbus) See Hosts on Errormessages Oct 30, 2024
@srebhan
Copy link
Member

srebhan commented Oct 30, 2024

@SoeNorKle please test the binary in PR #16114, available once CI finished the tests, and let me know if that's what you had in mind. I've added either the configured device setting or the controller setting (for connection related issues) to the error messages...

@srebhan srebhan self-assigned this Oct 30, 2024
@SoeNorKle
Copy link
Author

@srebhan Thanks for your effort. The code looks good and you changed more than I needed but thats great. I'll test the binary but I've no test environment atm. I'll let you know if I could test it and could generate some Errors to validate your adaptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new plugin and for new features to existing plugins
Projects
None yet
2 participants