Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) Top Margin & Scroll Flash #189

Merged
merged 6 commits into from
May 1, 2023
Merged

(fix) Top Margin & Scroll Flash #189

merged 6 commits into from
May 1, 2023

Conversation

mazenchami
Copy link
Collaborator

@mazenchami mazenchami commented Apr 28, 2023 •
edited
Loading

Description

#186
#162

Some Info related screens has extra crazy padding, fixing that.
AI swipe keyboard away with down gesture

Graphics

Before After






Checklist:

  • I have done a thorough self-review of my code
  • I have tested with a screen reader and font-scaling turned on and added necessary accessibility features
  • I have run tests and linter

@mazenchami mazenchami self-assigned this Apr 28, 2023
@mazenchami mazenchami mentioned this pull request May 1, 2023
Merged
3 tasks
mazenchami
mazenchami commented May 1, 2023
View reviewed changes
app/app.tsx Outdated
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these updates are removal of CustomToast and OTAUpdates into components folder to clean this file up

@mazenchami mazenchami requested a review from morganick May 1, 2023 12:51
@mazenchami mazenchami marked this pull request as ready for review May 1, 2023 12:51
morganick
morganick requested changes May 1, 2023
View reviewed changes
Copy link
Contributor

@morganick morganick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change.

app/screens/InfoScreen/InfoScreen.tsx Show resolved Hide resolved
@mazenchami mazenchami requested a review from morganick May 1, 2023 15:33
morganick
morganick approved these changes May 1, 2023
View reviewed changes
Copy link
Contributor

@morganick morganick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mazenchami mazenchami merged commit 2b3bcb8 into main May 1, 2023
@mazenchami mazenchami deleted the fix/top-padding-scroll-flash branch May 1, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morganick morganick morganick approved these changes

Assignees

@mazenchami mazenchami

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mazenchami @morganick