Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) OTA with expo-updates #183

Merged
merged 21 commits into from
Apr 28, 2023
Merged

(feat) OTA with expo-updates #183

merged 21 commits into from
Apr 28, 2023

Conversation

mazenchami
Copy link
Collaborator

@mazenchami mazenchami commented Apr 28, 2023 •
edited
Loading

Description

#182

This PR adds in the necessary code for expo-updates and also runs through a couple tests to make sure its working as expected.

Additionally, we created a Modal component and upgraded to Expo48

Graphics

Loom Video

Checklist:

  • I have done a thorough self-review of my code
  • I have tested with a screen reader and font-scaling turned on and added necessary accessibility features
  • I have run tests and linter

@mazenchami mazenchami self-assigned this Apr 28, 2023
@mazenchami mazenchami changed the title Feat/expo updates (feat) OTA with expo-updates Apr 28, 2023
@mazenchami mazenchami marked this pull request as ready for review April 28, 2023 18:52
frankcalise
frankcalise reviewed Apr 28, 2023
View reviewed changes
Copy link
Collaborator

@frankcalise frankcalise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some notes, great work!

app/screens/DebugScreen.tsx Outdated Show resolved Hide resolved
eas.json Outdated Show resolved Hide resolved
app/app.tsx Outdated Show resolved Hide resolved
app.config.ts Show resolved Hide resolved
@mazenchami mazenchami requested a review from frankcalise April 28, 2023 19:44
frankcalise
frankcalise reviewed Apr 28, 2023
View reviewed changes
app/app.tsx Outdated Show resolved Hide resolved
frankcalise
frankcalise approved these changes Apr 28, 2023
View reviewed changes
Copy link
Collaborator

@frankcalise frankcalise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :: passes to @robinheinze ::

@mazenchami
Copy link
Collaborator Author

Merging for now, will address comments @robinheinze & @morganick might have first thing on Monday!

@mazenchami mazenchami merged commit f52f40c into main Apr 28, 2023
@mazenchami mazenchami deleted the feat/expo-updates branch April 28, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinheinze robinheinze robinheinze left review comments

@frankcalise frankcalise frankcalise approved these changes

@morganick morganick Awaiting requested review from morganick

Assignees

@mazenchami mazenchami

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mazenchami @frankcalise @robinheinze @morganick