Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update OpenID4VP to WG Draft 20 #62

Merged
merged 21 commits into from
Mar 28, 2024
Merged

feat: update OpenID4VP to WG Draft 20 #62

merged 21 commits into from
Mar 28, 2024

Conversation

nanderstabel
Copy link
Collaborator

@nanderstabel nanderstabel commented Feb 26, 2024 •
edited
Loading

Description of change

#60 needs to be merged first.

This change updates the openid4vp crate in order to conform to OpenID4VP WG Draft 20

Links to any relevant issues

#59

How the change has been tested

No tests are added, but some existing tests are updated.

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@nanderstabel nanderstabel changed the title Feat/oid4vp wg draft 20 feat: update OpenID4VP to WG Draft 20 Feb 26, 2024
@nanderstabel nanderstabel mentioned this pull request Jan 12, 2024
Closed
3 tasks
@nanderstabel
chore: change ClaimFormatProperty's vector to a Vec<String>
436ba85 
There was no reason to use a `Vec<serde_json::Value>` since the
claim formats are always strings.
@nanderstabel
refactor: change ClientMetadata to an enum that can represent `clie…
7a12f58 
…nt_metadata_uri`

The added benefit is that `SIOPv2` and `OID4VP` specific fields can be
added to the `ClientMetadata` enum without affecting the `OID4VC` core
library.
@nanderstabel
feat: add vp_formats client metadata field
4372e21 
Also added tests for the updated Client Metadata for OID4VP
@nanderstabel
chore: update siopv2's with ClientMetadataEnum, update `oid4vc-mana…
d30505c 
…ger`'s `implicit` test
@nanderstabel nanderstabel changed the base branch from dev to feat/oid4vci-wg-draft-12 February 29, 2024 12:10
@nanderstabel nanderstabel changed the base branch from feat/oid4vci-wg-draft-12 to dev February 29, 2024 12:10
@nanderstabel nanderstabel added the Breaking change A change to the API that requires a major release. label Feb 29, 2024
@nanderstabel nanderstabel marked this pull request as ready for review February 29, 2024 12:28
@nanderstabel nanderstabel force-pushed the feat/oid4vp-wg-draft-20 branch from 07ccd71 to 8703a31 Compare February 29, 2024 13:03
@nanderstabel nanderstabel force-pushed the feat/oid4vp-wg-draft-20 branch from 8703a31 to ec4bbcc Compare February 29, 2024 13:07
@nanderstabel nanderstabel mentioned this pull request Feb 29, 2024
Merged
6 tasks
@nanderstabel nanderstabel force-pushed the feat/oid4vp-wg-draft-20 branch from 88d556a to d7e23d5 Compare March 27, 2024 18:22
@nanderstabel nanderstabel merged commit ff10842 into dev Mar 28, 2024
@nanderstabel nanderstabel deleted the feat/oid4vp-wg-draft-20 branch March 28, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-mader daniel-mader daniel-mader approved these changes

Assignees
No one assigned
Labels
Breaking change A change to the API that requires a major release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nanderstabel @daniel-mader