feat: update SIOPv2 to WG Draft 13 #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanderstabel
changed the title
3 tasks
There was no reason to use a `Vec<serde_json::Value>` since the claim formats are always strings.
…nt_metadata_uri` The added benefit is that `SIOPv2` and `OID4VP` specific fields can be added to the `ClientMetadata` enum without affecting the `OID4VC` core library.
Also added tests for the updated Client Metadata for OID4VP
…ger`'s `implicit` test
nanderstabel
force-pushed
the
feat/siopv2-wg-draft-13
branch
from
07ccd71 to
6384450
Compare
nanderstabel
changed the title
nanderstabel
added
the
Breaking change
nanderstabel
force-pushed
the
feat/siopv2-wg-draft-13
branch
from
ce563fd to
4b5ea00
Compare
nanderstabel
force-pushed
the
feat/siopv2-wg-draft-13
branch
from
4b5ea00 to
30963a5
Compare
as described here: https://openid.net/specs/openid-connect-self-issued-v2-1_0.html#name-a-set-of-static-configuratio This implementation uses `openid` as the defautl custom URL scheme, but it can by the user.
nanderstabel
force-pushed
the
feat/siopv2-wg-draft-13
branch
from
30963a5 to
dd0bb4c
Compare
nanderstabel
changed the title
1 task
daniel-mader
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
#62 needs to be merged first.
Updated the
siopv2crate to WG Draft 13: https://openid.net/specs/openid-connect-self-issued-v2-1_0-13.htmlSince there are no significant changes since the current version, only the option to set the custom URL scheme (using
openidas default, see here) has been implemented and some links have been updated.Links to any relevant issues
#59
fixes #19
How the change has been tested
Existing tests still pass.
Definition of Done checklist
Add an
xto the boxes that are relevant to your changes.