-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report CO₂ emissions from transportation #134
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #134 +/- ##
=======================================
+ Coverage 71.5% 73.3% +1.8%
=======================================
Files 80 82 +2
Lines 5439 5663 +224
=======================================
+ Hits 3889 4152 +263
+ Misses 1550 1511 -39
|
Matches snapshot contents.
khaeru
added
enh
New features or functionality
report
genno-based reporting and post-solve processing
transport
MESSAGEix-Transport variant or transport in the base model
labels
Oct 25, 2023
3 tasks
khaeru
force-pushed
the
enh/report-emi
branch
2 times, most recently
from
October 30, 2023 14:03
24a561c
to
5a6175f
Compare
Suppress warnings from actions/setup-python
khaeru
force-pushed
the
enh/report-emi
branch
2 times, most recently
from
October 30, 2023 14:25
df84248
to
9e17e46
Compare
khaeru
force-pushed
the
enh/report-emi
branch
from
October 30, 2023 14:37
9e17e46
to
519bdfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds code that mirrors the behaviour of
message_data
(‘legacy’) reporting, as an exploration of how to exactly replicate these calculations usinggenno
. For this purpose, the code only replaces the portions ofmessage_data.tools.post_processing.default_tables.retr_CO2emi
that calculate CO₂ emissions from transportation.The goals are:
message_data
. (However, per this Slack thread, there does not exist a legacy reporting output for the snapshot, and it would be difficult to produce one due to changes to the units.)Some things specifically omitted, that could be tackled in follow-up PRs:
out:*
earlier, in a single operation for all technologies that share the same units ofACT
andoutput
.Housekeeping
genno.Operator.define
to avoid mypy complaints in "Code quality" CI job (FYI @glatterf42)How to review
See:
PR checklist