Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test and improve .report #119

Closed
wants to merge 3 commits into from
Closed

Test and improve .report #119

wants to merge 3 commits into from

Conversation

khaeru
Copy link
Member

@khaeru khaeru commented Aug 31, 2023

Will close #118.

How to review

TBA

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation.
  • Update doc/whatsnew.

@khaeru khaeru self-assigned this Aug 31, 2023
@khaeru khaeru added the enh New features or functionality label Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #119 (f65d250) into main (2f62b67) will increase coverage by 1.5%.
The diff coverage is 97.4%.

@@           Coverage Diff           @@
##            main    #119     +/-   ##
=======================================
+ Coverage   66.9%   68.5%   +1.5%     
=======================================
  Files         70      71      +1     
  Lines       4635    4669     +34     
=======================================
+ Hits        3104    3200     +96     
+ Misses      1531    1469     -62     
Files Changed Coverage Δ
message_ix_models/tests/test_cli.py 100.0% <ø> (ø)
message_ix_models/report/computations.py 57.3% <80.0%> (+18.3%) ⬆️
...essage_ix_models/tests/report/test_computations.py 100.0% <100.0%> (ø)
message_ix_models/tests/report/test_sim.py 100.0% <100.0%> (ø)

... and 2 files with indirect coverage changes

@khaeru
Copy link
Member Author

khaeru commented Oct 30, 2023

Changes picked up in #134 and others.

@khaeru khaeru closed this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enh New features or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test and improve .report
1 participant