Reduce memory usage: do not allocate memory for the transform layer for single layer images #7233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rework most image processing functions to work with singleLayer images without 'transform' layer.
Districh-ru
added
improvement
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Districh-ru
changed the title
…r, change while loops to memcpy/fill
… effect (Battlefield)
…actCommonPattern() to properly work with single layer images
ihhub
requested changes
May 28, 2023
There was a problem hiding this comment.
Hi @Districh-ru , I left several comments in this pull request. Would you mind to take a look at them?
…nsformPixel()' (disable transform layer instead and update only image data layer)
Districh-ru
added
the
low priority
|
Closing this PR in favor to #8241 |
Districh-ru
deleted the
disable_transform_layer_for_singlelayer_images
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables the
transformlayer for images that are set assingleLayerand reworks the image processing functions not to work with this layer for such images.For 1366x768 resolution with opened View World for XL map the engine takes 72 MB, in master build - 82 MB.