-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't interact with the transform layer if the image is a single layer #8149
base: master
Are you sure you want to change the base?
Don't interact with the transform layer if the image is a single layer #8149
Conversation
Hi @Districh-ru , let's target this pull request for the next release. I think we might need to add assertions to verify this changes. |
Hi, @ihhub, sure, let's postpone it to v. 1.1.0. |
…x setResolution()
Hi @Districh-ru , I hit the assertion in Credits within |
Thanks, I'll check it. Previously I checked only the gameplay :) |
Hi @Districh-ru , I believe we will need to rewrite Resize() function for this matter. I recommend not to spend too much time at the moment doing this unless a fix is very trivial. |
Yes a fix is to make But I plan to rewrite Resize today. :) |
@Districh-ru , then cool :) |
…nt number of layers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
Hi @Districh-ru , it looks good but I will play around for a couple of days to make sure that no other places hit the assertion. |
Sure, I'll do the same. |
This reverts commit 8782450.
….com/Districh-ru/fheroes2 into single-layer-do-not-access-transform
There is no need to set new data for the transform layer if the image is already in single layer mode - the transform layer will never be accessed.