Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Wrist section overhaul (#328)" #341

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

Nicogene
Copy link
Member

This reverts commit 5ce8d7c.

@Lawproto probably just reverting is not sufficient

@Nicogene Nicogene mentioned this pull request Mar 13, 2024
@pattacini
Copy link
Member

@Lawproto you can work on this fork/branch to complete the work.

@Nicogene Nicogene marked this pull request as ready for review March 14, 2024 13:12
@Nicogene Nicogene requested a review from pattacini as a code owner March 14, 2024 13:12
@Nicogene
Copy link
Member Author

@pattacini and I decided to apply this change which is required anyways.

@Lawproto please review the final outcome and start your work from here.
Given that right and left behave specularly we do not need the image that contains both wrists; we just need to revise the table inserting [l|r]_...

@Nicogene Nicogene merged commit c9e9807 into icub-tech-iit:master Mar 14, 2024
1 check passed
@Nicogene Nicogene deleted the rev328 branch March 14, 2024 13:15
@Nicogene Nicogene linked an issue Mar 14, 2024 that may be closed by this pull request
@Lawproto
Copy link
Member

@Nicogene it is possible the direction of the arrows in the image has to be fixed too to match the positive value of the angle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert #328
3 participants