Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #328 #336

Closed
pattacini opened this issue Feb 27, 2024 · 4 comments · Fixed by #341 or #345
Closed

Revert #328 #336

pattacini opened this issue Feb 27, 2024 · 4 comments · Fixed by #341 or #345
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@pattacini
Copy link
Member

After an internal discussion during our board meeting, we decided to revert PR #328.

This is because the convention for the CSYS is limited to the alignment of their axes wrt a resting position of the robot, but doesn't include the directions of rotation. In practical terms, this means that the same joint angles guarantee a specular symmetry between the arms.

Reverting #328 is as simple as clicking a button, although we may need to carry out a careful review.

cc @Lawproto @Nicogene @fiorisi @traversaro

@pattacini pattacini added the documentation Improvements or additions to documentation label Feb 27, 2024
@Nicogene
Copy link
Member

I opened a PR with just the commit reverted:

But it seems not sufficient, more refinement is needed.

@Nicogene Nicogene linked a pull request Mar 14, 2024 that will close this issue
@pattacini
Copy link
Member Author

A gentle reminder for @Lawproto.
cc @Nicogene

@Lawproto
Copy link
Member

@pattacini there you go:

@pattacini pattacini linked a pull request Mar 28, 2024 that will close this issue
@pattacini
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
3 participants