Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the DefaultThreadCurrentUICulture to a specific culture, asserted error language consistency #1150

Merged
merged 1 commit into from
Nov 9, 2024
Merged

Set the DefaultThreadCurrentUICulture to a specific culture, asserted error language consistency #1150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Tests/TestRunners/ConverterTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
using Microsoft.CodeAnalysis.VisualBasic;
using Xunit;
using Xunit.Sdk;
using System.Globalization;

namespace ICSharpCode.CodeConverter.Tests.TestRunners;

Expand All @@ -28,6 +29,7 @@ public class ConverterTestBase

public ConverterTestBase(string rootNamespace = null)
{
CultureInfo.DefaultThreadCurrentUICulture = CultureInfo.InvariantCulture;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have: Haven't had need to try this yet, but may be worth trying putting in a ModuleInitializer so it definitely covers the whole test suite rather than some tests running with it and some without.

_rootNamespace = rootNamespace;
var options = new VisualBasicCompilationOptions(OutputKind.DynamicallyLinkedLibrary)
.WithOptionExplicit(true)
Expand Down
Loading