Set the DefaultThreadCurrentUICulture to a specific culture, asserted error language consistency #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e if the current computer culture is not en-US a lot of asserts will fail, because the language of the error might not be english.
| @@ -28,6 +29,7 @@ public class ConverterTestBase | |||
|
|
|||
| public ConverterTestBase(string rootNamespace = null) | |||
| { | |||
| CultureInfo.DefaultThreadCurrentUICulture = CultureInfo.InvariantCulture; | |||
There was a problem hiding this comment.
Nice to have: Haven't had need to try this yet, but may be worth trying putting in a ModuleInitializer so it definitely covers the whole test suite rather than some tests running with it and some without.
|
Thanks, I'll try to move it to a module initializer now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#1145
Solution
By setting DefaultThreadCurrentUICulture to CultureInfo.InvariantCulture, in the base class of the unit tests, it ensure that the asserted build error text and actual error text will be in the same language