Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-5705: Fixed InteractiveLoginToken using PostAuthenticationGuardToken #274

Merged
merged 9 commits into from
Sep 19, 2023
Merged

IBX-5705: Fixed InteractiveLoginToken using PostAuthenticationGuardToken #274

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
eeb3e59
IBX-5705: Fixed InteractiveLoginToken using PostAuthenticationGuardToken
Nattfarinn Sep 15, 2023
936d287
fix: Add comment to explain why such change
Nattfarinn Sep 15, 2023
71dee3d
fix: Reuse original token state instead of force authenticated
Nattfarinn Sep 18, 2023
04da343
fix: Code style
Nattfarinn Sep 18, 2023
71d0e7a
fix: Rename method to make it consistent
Nattfarinn Sep 18, 2023
0ecddcf
fix: Append nullable type
Nattfarinn Sep 18, 2023
8d8b4a4
Update src/lib/MVC/Symfony/Security/InteractiveLoginToken.php
Nattfarinn Sep 18, 2023
af37766
fix: Phpstan
Nattfarinn Sep 19, 2023
164cd09
fix: Code review
Nattfarinn Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/lib/MVC/Symfony/Security/InteractiveLoginToken.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
namespace Ibexa\Core\MVC\Symfony\Security;

use Symfony\Component\Security\Core\Authentication\Token\UsernamePasswordToken;
use Symfony\Component\Security\Guard\Token\PostAuthenticationGuardToken;

/**
* This token is used when a user has been matched by a foreign user provider.
Expand Down Expand Up @@ -41,6 +42,15 @@ public function __unserialize($serialized): void
[$this->originalTokenType, $parentStr] = $serialized;
parent::__unserialize($parentStr);
}

public function isAuthenticated(): bool
{
if (PostAuthenticationGuardToken::class === $this->originalTokenType) {
return true;
}

return parent::isAuthenticated();
}
alongosz marked this conversation as resolved.
Show resolved Hide resolved
}

class_alias(InteractiveLoginToken::class, 'eZ\Publish\Core\MVC\Symfony\Security\InteractiveLoginToken');