-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-5705: Fixed InteractiveLoginToken using PostAuthenticationGuardToken #274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from failing code style.
Co-authored-by: Paweł Niedzielski <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested together with https://github.com/ibexa/oauth2-server/pull/21/files , looks good!
v4.6
InteractiveLoginToken
wrappingPostAuthenticationGuardToken
has to be authenticated by default, otherwise it leads to unexpected Symfony behaviour.Fixes issue in OAuth2 Server: https://github.com/ibexa/oauth2-server/pull/21
Symfony ref. https://github.com/symfony/security-guard/blob/5.4/Token/PostAuthenticationGuardToken.php#L50-L51
Checklist:
$ composer fix-cs
).@ibexa/engineering
).