Code checker fixes #51
Conversation
lucaboesch
force-pushed
the
codecheckerfixes
branch
from
3689030 to
5f2d881
Compare
| @@ -139,7 +109,7 @@ jobs: | |||
|
|
|||
| - name: Validating | |||
| if: ${{ always() }} | |||
| run: moodle-plugin-ci validate | |||
| run: moodle-plugin-ci validate || true | |||
There was a problem hiding this comment.
Hi @lucaboesch Why are we ignoring the outcome of the moodle-plugin-ci validate command? Just trying to understand the logic behind this particular change 😄
There was a problem hiding this comment.
Oh, I see. validate doesn't know about class aliases, and fails with a "failed to find class filter_multilang2" error.
|
It would fail because there is no class in filter.php. |
| continue-on-error: true # This step will show errors but will not fail | ||
| if: ${{ always() }} | ||
| run: moodle-plugin-ci phpcpd | ||
|
|
||
| - name: PHP Mess Detector |
There was a problem hiding this comment.
@lucaboesch Why are we removing this check? Is it no longer supported by moodle-plugin-ci?
There was a problem hiding this comment.
I see it has been marked deprecated. Fair enough!
| @@ -139,7 +109,7 @@ jobs: | |||
|
|
|||
| - name: Validating | |||
| if: ${{ always() }} | |||
| run: moodle-plugin-ci validate | |||
| run: moodle-plugin-ci validate || true | |||
There was a problem hiding this comment.
Oh, I see. validate doesn't know about class aliases, and fails with a "failed to find class filter_multilang2" error.
Here are additional fixes to let the CI tests pass.