Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to Moodle 4.5 (adapt to MDL-82427) #50

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

izendegi
Copy link
Collaborator

@izendegi izendegi commented Oct 8, 2024

Kaixo, Iñaki

Following the tips at #49 I've tried to make the changes needed to support both Moodle 4.5 and previous versions.

It seems to work, but I haven't tested it extensively.

@iarenaza
Copy link
Owner

iarenaza commented Oct 8, 2024

Kaixo Iñigo!

Lehenik eta behin, eskerrik asko petaxuagatik! Unfortunately, it doesn't seem to work with (most? all?) versions earlier to 4.5 (as seen by the CI checks failures). We need to add the "backwards compatibility" changes mentioned in #49.

Additionally, I need to expand the CI check matrix to include Moodle 4.4 and 4.5 (I didn't back in the day), and PHP 8.2 and 8.3.

I'll have a look at it as soon as I have some spare time (I expect to have some today and tomorrow), but I can't promise an ETA.

@lucaboesch
Copy link
Contributor

I've added a Pull Request to re-enable functioning CI tests under #51

@KepaUrzelai KepaUrzelai merged commit 38d2d97 into master Oct 8, 2024
0 of 56 checks passed
@KepaUrzelai
Copy link
Collaborator

Hello guys,

With this commit, we can now release a new version for the plugin. Only compatible with Moodle 4.2, 4.3, 4.4 and 4.5 due to PHP versions.

Thanks for working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants