update voucher hub whit check on transfer

iExecBlockchainComputing · Jun 10, 2024 · 1b58543 · 1b58543
1 parent f7a51f1
commit 1b58543
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 2 deletions.
diff --git a/contracts/VoucherHub.sol b/contracts/VoucherHub.sol
@@ -172,7 +172,10 @@ contract VoucherHub is
         // The proxy contract does a delegatecall to its implementation.
         // Re-Entrancy safe because the target contract is controlled.
         Voucher(voucherAddress).initialize(owner, address(this), expiration, voucherType);
-        IERC20($._iexecPoco).transfer(voucherAddress, value); // SRLC
+        if (!IERC20($._iexecPoco).transfer(voucherAddress, value)) {
+            // SRLC
+            revert("VoucherHub: SRLC transfer to voucher failed");
+        }
         _mint(voucherAddress, value); // VCHR
         $._isVoucher[voucherAddress] = true;
         emit VoucherCreated(voucherAddress, owner, voucherType, expiration, value);
@@ -188,7 +191,10 @@ contract VoucherHub is
         VoucherHubStorage storage $ = _getVoucherHubStorage();
         require($._isVoucher[voucher], "VoucherHub: unknown voucher");
         _mint(voucher, value); // VCHR
-        IERC20($._iexecPoco).transfer(voucher, value); // SRLC
+        if (!IERC20($._iexecPoco).transfer(voucher, value)) {
+            // SRLC
+            revert("VoucherHub: SRLC transfer to voucher failed");
+        }
         uint256 expiration = block.timestamp + $.voucherTypes[Voucher(voucher).getType()].duration;
         Voucher(voucher).setExpiration(expiration);
         emit VoucherToppedUp(voucher, expiration, value);

diff --git a/test/VoucherHub.test.ts b/test/VoucherHub.test.ts
@@ -668,6 +668,22 @@ describe('VoucherHub', function () {
                 ),
             ).to.be.revertedWith('VoucherHub: type index out of bounds');
         });
+        it('Should not create voucher when SLRC transfer fails', async function () {
+            const { voucherOwner1 } = await loadFixture(deployFixture);
+            await voucherHubWithAssetEligibilityManagerSigner.createVoucherType(
+                description,
+                duration,
+            );
+            await iexecPocoInstance.willRevertOnTransfer().then((tx) => tx.wait());
+            // Create voucher.
+            await expect(
+                voucherHubWithVoucherManagerSigner.createVoucher(
+                    voucherOwner1,
+                    voucherType,
+                    voucherValue,
+                ),
+            ).to.be.revertedWith('VoucherHub: SRLC transfer to voucher failed');
+        });
     });
 
     describe('Top up voucher', function () {
@@ -737,6 +753,14 @@ describe('VoucherHub', function () {
                 ),
             ).to.revertedWith('VoucherHub: unknown voucher');
         });
+        it('Should not top up when SLRC transfer fails', async function () {
+            const topUpValue = 123n; // arbitrary value
+            await iexecPocoInstance.willRevertOnTransfer().then((tx) => tx.wait());
+            // Create voucher.
+            await expect(
+                voucherHubWithVoucherManagerSigner.topUpVoucher(voucherAddress, topUpValue),
+            ).to.be.revertedWith('VoucherHub: SRLC transfer to voucher failed');
+        });
     });
 
     describe('Debit voucher', function () {