add slither github action (#24)

.github/workflows/main.yml

@@ -21,3 +21,16 @@ jobs:
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
           slug: iExecBlockchainComputing/iexec-voucher-contracts
+      - name: Run static analysis with slither
+        uses: crytic/[email protected]
+        id: slither
+        with:
+          target: "contracts/"
+          slither-args: --checklist --markdown-root ${{ github.server_url }}/${{ github.repository }}/blob/${{ github.sha }}/
+          node-version: "20"
+          fail-on: none # TODO set this to high or other
+          sarif: results.sarif
+      - name: Upload SARIF file
+        uses: github/codeql-action/upload-sarif@v3
+        with:
+          sarif_file: ${{ steps.slither.outputs.sarif }}

CHANGELOG.md

@@ -1,6 +1,7 @@
 # Changelog
 
 ## vNEXT
+- Add slither github action. (#24)
 - Top up voucher. (#23)
 - Claim task part 2 - Add voucher tests. (#21)
 - Claim task part 1 - Solidity with minimal tests. (#20)

hardhat.config.ts

@@ -62,6 +62,7 @@ const config: HardhatUserConfig = {
     },
     dependencyCompiler: {
         paths: ['@openzeppelin/contracts/proxy/beacon/UpgradeableBeacon.sol'],
+        keep: true, // Keep it for slither
     },
 };
 

slither.config.json

@@ -0,0 +1,5 @@
+{
+    "solc_remaps": "@=node_modules/@",
+    "filter_paths": "(mocks/|node_modules/)",
+    "solc_args": "--optimize --via-ir"
+}