Switch to warning/1 with updated build matrix #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subzero10
approved these changes
Jun 15, 2023
|
@sorentwo Since we are bumping the minimum required version of Elixir, should this be a major version release? Finally, the tests are failing, can you make sure they pass so that we can merge? Thanks! |
|
What can I do to help get this across goal line? |
|
@tjchambers Sorry, I totally forgot about this one. |
|
bump? |
sorentwo
force-pushed
the
logger-warning
branch
2 times, most recently
from
2d613cd to
66efe0c
Compare
|
@subzero10 @tjchambers, some extra work was required to get this passing cleanly. All set now! |
subzero10
reviewed
Oct 31, 2023
subzero10
approved these changes
Nov 1, 2023
|
I think we can merge and push a release as soon as the conflicts are resolved. |
This swiitches from `Logger.warn` to `Logger.warning` because `warn` is deprecated and Elixir 1.15 shows a compile-time warning. The `warning` alternative was introduced in Elixir 1.11, so we're updating the build matrix to officially support 1.11 as the minimum Elixir version.
Only applications that aren't listed as depenencies, or their sub-dependencies, should be listed.
Config files are meant for applications, not libraries.
sorentwo
force-pushed
the
logger-warning
branch
from
3ad847e to
b9a2a57
Compare
|
@subzero10 Rebased. Once CI passes, I'll merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This swiitches from
Logger.warntoLogger.warningbecausewarnis deprecated, and the upcoming Elixir 1.15 shows a compile-time warning. Thewarningalternative was introduced in Elixir 1.11, so we're officially updating the build matrix to support 1.11 as the minimum Elixir version.Closes #493