Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace Logger.warn/1 with Logger.warning/2 #523

Conversation

abshierjoel
Copy link
Contributor

Closes #493

Elixir 1.15 deprecated Logger.warn/1 in favor of the new Logger.warning/2. @tjchambers proposed a solution to maintain compatibility for Elixir < 1.10 but since the readme already lists >= 1.10 as a requirement, I figured this change could just be made directly.

@abshierjoel
Copy link
Contributor Author

Apologies, I missed that #495 was already opened and resolves this with the bump in Elixir version. No need for this PR.

@subzero10
Copy link
Member

Apologies, I missed that #495 was already opened and resolves this with the bump in Elixir version. No need for this PR.

No worries! Thanks for helping out! Since you are on the topic, can you please have a look at #495 and see why the tests are failing?

@abshierjoel
Copy link
Contributor Author

@subzero10
For sure! I'll take a look tomorrow morning and see if I can get it working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logger.warn is deprecated
2 participants