Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document zwave_js changes for lib bump to 0.52.0 #29036

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

raman325
Copy link
Contributor

Proposed change

The term heal has been changed to rebuild routes. We have changed the language in the backend and in the frontend in the linked PRs, but need to update the docs as well.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@raman325 raman325 requested a review from a team as a code owner September 26, 2023 18:18
@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Sep 26, 2023
@raman325 raman325 marked this pull request as draft September 26, 2023 18:30
@raman325 raman325 marked this pull request as ready for review September 26, 2023 18:53
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should update the section about logging.

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft September 26, 2023 21:12
@raman325
Copy link
Contributor Author

raman325 commented Sep 26, 2023

I think we should update the section about logging.

In what sense? There is a separate PR for adding the logging feature to the core and a separate corresponding docs PR

@MartinHjelmare
Copy link
Member

That's what I meant.

@raman325
Copy link
Contributor Author

So is any change needed here or are we good to merge as is?

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're good.

@raman325 raman325 marked this pull request as ready for review September 26, 2023 22:58
@raman325 raman325 merged commit cf23df2 into home-assistant:next Sep 26, 2023
6 checks passed
@raman325 raman325 deleted the 12 branch September 26, 2023 22:58
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants