Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump zwave-js-server-python to 0.52.0 #100833

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Conversation

raman325
Copy link
Contributor

@raman325 raman325 commented Sep 25, 2023

Breaking change

  • Multiple websocket commands have been renamed based on the following change in Z-Wave JS: https://zwave-js.github.io/node-zwave-js/#/getting-started/migrating-to-v12?id=renamed-network-heal-to-rebuild-routes
  • With this release, you will need to update your zwave-js-server instance. You must use zwave-js-server 1.32.0 or greater (schema 32).
    • If you use the Z-Wave JS add-on, you need at least version 0.1.91.
    • If you use the Z-Wave JS UI add-on, you need at least version ??.
    • If you use the Z-Wave JS UI Docker container, you need at least version ??.
    • If you run your own Docker container or some other installation method, you will need to update your zwave-js-server instance to at least 1.32.0.

Proposed change

A proper changelog will be included here but this will have to do for now:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration (zwave_js) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zwave_js can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zwave_js Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@MartinHjelmare
Copy link
Member

MartinHjelmare commented Sep 26, 2023

Make sure to add a breaking change paragraph to the PR description.

@raman325 raman325 marked this pull request as ready for review September 26, 2023 18:54
@raman325 raman325 requested a review from a team as a code owner September 26, 2023 18:54
@raman325 raman325 removed the waiting-for-upstream We're waiting for a change upstream label Sep 26, 2023
@raman325
Copy link
Contributor Author

note that once this is approved, we need to merge home-assistant/addons#3227 before we merge this

@raman325
Copy link
Contributor Author

this will also require merging of the linked frontend PR since the websocket command names are changing

@raman325 raman325 merged commit 176f5dc into home-assistant:dev Sep 26, 2023
34 checks passed
@raman325 raman325 deleted the bump branch September 26, 2023 21:05
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants