Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "limit" instead of "mode" for Numeric state trigger and condition #23360

Merged
merged 4 commits into from
Dec 22, 2024
Merged

Use "limit" instead of "mode" for Numeric state trigger and condition #23360

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ed3da13
Use "limit" instead of "mode" for Numeric state trigger and condition
NoRi2909 Dec 20, 2024
9d2cbc8
Change key names to lower_limit and upper_limit in strings.json
NoRi2909 Dec 22, 2024
bbd5dcf
Update ha-automation-trigger-numeric_state.ts
NoRi2909 Dec 22, 2024
c0dde90
Update ha-automation-condition-numeric_state.ts
NoRi2909 Dec 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/translations/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3166,8 +3166,8 @@
"label": "Numeric state",
"above": "Above",
"below": "Below",
"mode_above": "Above mode",
"mode_below": "Below mode",
"mode_above": "Lower limit",
"mode_below": "Upper limit",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should rename the key names if we are going to use them as a description for the entire section.

Copy link
Contributor Author

@NoRi2909 NoRi2909 Dec 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure makes sense for consistency. Then we need to also rename them for the condition as this references the labels from the trigger:

frontend/src/translations/en.json

Lines 3383 to 3384 in 0a28bbd

"mode_above": "[%key:ui::panel::config::automation::editor::triggers::type::numeric_state::mode_above%]",
"mode_below": "[%key:ui::panel::config::automation::editor::triggers::type::numeric_state::mode_below%]",

Shall I go ahead with that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please 👍

Copy link
Contributor Author

@NoRi2909 NoRi2909 Dec 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the additional changes in the strings.json but I'm afraid that the necessary changes in

ha-automation-trigger-numeric_state.ts
ha-automation-condition-numeric_state.ts

are beyond my rudimentary programming skills and what the GitHub web editor allows me to mess with …

Edit: I figured out my way round the editor and did a full find & replace on both. Now let's see …

"value_template": "Value template",
"type_value": "Fixed number",
"type_input": "Numeric value of another entity",
Expand Down
Loading