Use "limit" instead of "mode" for Numeric state trigger and condition #23360
Conversation
Currently the labels for "Above" and "Below" sections of the Numeric state trigger and condition are called "Above mode" and "Below mode". As modes are always exclusive – you can't have two modes enabled at the same time – this labeling is misleading as you can specify both a lower and an upper limit. By changing them to "Lower limit" and "Upper limit" it becomes clear that the user can specify either or both at the same time. As the field labels remain "Above" and "Below" and the summary also explains it that way it remains clear the limits are exclusive.
|
The label is actually just for the radio, but I get your point |
src/translations/en.json
Outdated
| "mode_above": "Lower limit", | ||
| "mode_below": "Upper limit", |
There was a problem hiding this comment.
I think we should rename the key names if we are going to use them as a description for the entire section.
There was a problem hiding this comment.
Sure makes sense for consistency. Then we need to also rename them for the condition as this references the labels from the trigger:
frontend/src/translations/en.json
Lines 3383 to 3384 in 0a28bbd
Shall I go ahead with that?
There was a problem hiding this comment.
I made the additional changes in the strings.json but I'm afraid that the necessary changes in
ha-automation-trigger-numeric_state.ts
ha-automation-condition-numeric_state.ts
are beyond my rudimentary programming skills and what the GitHub web editor allows me to mess with …
Edit: I figured out my way round the editor and did a full find & replace on both. Now let's see …
Proposed change
Currently the labels for "Above" and "Below" sections of the Numeric state trigger and condition are called "Above mode" and "Below mode":
As modes are always exclusive – you can't have two modes enabled at the same time – this labeling is misleading as you can specify both a lower and an upper limit.
By changing them to "Lower limit" (instead if "Above mode") and "Upper limit" (instead of "Below mode") it becomes clear that the user can specify either or both at the same time.
As the field labels remain "Above" and "Below" and the summary also explains it that way it remains clear the limits are exclusive.
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: