Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iframe strategy #20068

Merged
merged 6 commits into from
Mar 21, 2024
Merged

Add iframe strategy #20068

merged 6 commits into from
Mar 21, 2024

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Mar 12, 2024

Proposed change

Add iframe strategy to replace the iframe panel.

Create a dashboard dialog

CleanShot 2024-03-12 at 12 19 04

Iframe dashboard

CleanShot 2024-03-12 at 12 21 14

UI editor

CleanShot 2024-03-12 at 12 20 35

YAML editor

CleanShot 2024-03-12 at 12 20 55

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@piitaya piitaya marked this pull request as draft March 12, 2024 11:23
@piitaya piitaya changed the title Iframe strategy Add iframe strategy Mar 12, 2024
@frenck frenck added the Noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) label Mar 12, 2024
@piitaya piitaya marked this pull request as ready for review March 15, 2024 10:22
src/translations/en.json Outdated Show resolved Hide resolved
@bramkragten bramkragten merged commit 90e9f79 into dev Mar 21, 2024
13 checks passed
@bramkragten bramkragten deleted the iframe-strategy branch March 21, 2024 12:44
@raulgbcr
Copy link

Is there any chance that we can configure HA iframes to have the "allow" tag included? Maybe as an advance setting?
This is useful for enabling autoplay and other behaviors on iframes

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe#allow

@frenck
Copy link
Member

frenck commented Mar 25, 2024

@raulgbcr This is not the place for feature requests. Please use our community forums for those.

Thanks 👍

../Frenck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants