Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two pane view to calendar panel #18286

Merged
merged 8 commits into from
Oct 23, 2023
Merged

Conversation

bramkragten
Copy link
Member

@bramkragten bramkragten commented Oct 19, 2023

Proposed change

Intoduces a two pane view, that turns into a 1 pane view on narrow screens:

CleanShot 2023-10-19 at 12 14 26

On mobile the header becomes a drop down menu that allows to pick the calendars that you want to show:

CleanShot 2023-10-19 at 12 14 48

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@github-actions github-actions bot added Dependencies Pull requests that update a dependency file Build Related to building the code labels Oct 19, 2023
@frenck frenck added the Noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) label Oct 19, 2023
@bramkragten bramkragten mentioned this pull request Oct 19, 2023
9 tasks
Copy link
Member

@piitaya piitaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed 2 things.

The lines are not aligned in some screen sizes. Also, do we really need this line in the top bar? 😅

CleanShot 2023-10-23 at 11 48 52

On mobile, does the dropdown needs to be closed on each checkbox click?

CleanShot.2023-10-23.at.11.40.06.mp4

src/components/ha-button-menu.ts Outdated Show resolved Hide resolved
@bramkragten
Copy link
Member Author

Also, do we really need this line in the top bar?

Yes, I think we do, especially if we are going to move controls to the right side of the top bar

@bramkragten bramkragten force-pushed the add-two-pane-view-calendar branch from 03855ea to bc843a8 Compare October 23, 2023 13:52
@bramkragten bramkragten enabled auto-merge (squash) October 23, 2023 14:02
@bramkragten bramkragten merged commit 463a324 into dev Oct 23, 2023
8 checks passed
@bramkragten bramkragten deleted the add-two-pane-view-calendar branch October 23, 2023 14:13
@@ -52,10 +52,12 @@
"@lezer/highlight": "1.1.6",
"@lit-labs/context": "0.4.1",
"@lit-labs/motion": "1.0.4",
"@lit-labs/observers": "2.0.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, this introduced a duplicate of @lit/reactive-element (bumping it to the next major version).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusted in #18484

@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Build Related to building the code cla-signed Dependencies Pull requests that update a dependency file hacktoberfest Noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants