Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for todo component #18289

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Add support for todo component #18289

merged 4 commits into from
Oct 23, 2023

Conversation

bramkragten
Copy link
Member

Proposed change

For: home-assistant/core#100019

Needs: #18286

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@github-actions github-actions bot added Dependencies Pull requests that update a dependency file Demo Related to frontend demo content labels Oct 19, 2023
demo/src/stubs/shopping_list.ts Outdated Show resolved Hide resolved
src/data/todo.ts Outdated
Comment on lines 6 to 9
export enum TodoItemStatus {
NeedsAction = "needs-action",
Completed = "completed",
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export enum TodoItemStatus {
NeedsAction = "needs-action",
Completed = "completed",
}
export type TodoItemStatus = "needs-action" | "completed"

Should we use literal instead of enum as we do this for other domain (e.g. climate hvac_modes)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I rather use the enum, but it should have been a const enum here

@github-actions github-actions bot added Build Related to building the code Design Related to Home Assistant design gallery labels Oct 23, 2023
@github-actions github-actions bot removed Dependencies Pull requests that update a dependency file Build Related to building the code labels Oct 23, 2023
@bramkragten bramkragten merged commit 2b9540f into dev Oct 23, 2023
12 checks passed
@bramkragten bramkragten deleted the add-todo branch October 23, 2023 20:53
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed Demo Related to frontend demo content Design Related to Home Assistant design gallery hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants