-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for todo component #18289
Conversation
src/data/todo.ts
Outdated
export enum TodoItemStatus { | ||
NeedsAction = "needs-action", | ||
Completed = "completed", | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export enum TodoItemStatus { | |
NeedsAction = "needs-action", | |
Completed = "completed", | |
} | |
export type TodoItemStatus = "needs-action" | "completed" |
Should we use literal instead of enum as we do this for other domain (e.g. climate hvac_modes
)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I rather use the enum, but it should have been a const
enum here
Proposed change
For: home-assistant/core#100019
Needs: #18286
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: