Allow saving the light current color as a favorite #17992
Conversation
| color_mode === LightColorMode.COLOR_TEMP && | ||
| attributes.color_temp_kelvin | ||
| ) { | ||
| this._color = { |
There was a problem hiding this comment.
We should also set the correct LightPickerMode in this._mode
There was a problem hiding this comment.
Mmmm I guess _updateModes does that, I think that logic should be refactored a bit so it makes more sense (combined)
There was a problem hiding this comment.
Not sure I get what you're asking for. You want to fold updateModes and loadCurrentColor into a single function?
I don't know if I see much refactoring opportunity there, there doesn't seem like too much overlap between them.
There was a problem hiding this comment.
The part that sets the _mode, I found it confusing that the _color and _mode are set at different places, as they are related, and both determined by the LightColorMode.
There was a problem hiding this comment.
Ok, I tried an alternate implementation. I'm not sure if I feel this is much better or less confusing, but it does set _color and _mode more consistently.
There was a problem hiding this comment.
not really I think 😅 now we are calculating the current color always and only use it when add == true
There was a problem hiding this comment.
Well I do only want the current color when creating a new preset, because otherwise the current color of the bulb is not what we want when editing an existing preset.
Let me know what's the path forward.
There was a problem hiding this comment.
Yeah, no I get that :-) I'll propose something tomorrow, it is really nitpicking anyway....
There was a problem hiding this comment.
I was thinking at another approach : passing the current color when editing a favorite and default to _loadCurrentColorAndMode if no favorite color is passed to the dialog (in case of adding a new color).
Also, this would means we don't have to pass the defaultMode anymore. But I agree with @bramkragten it's nitpicking. I'm ok to merge this one to fix the issue and we can refactor to improve code quality after if needed.
Proposed change
Allow to save the current light's color as a favorite, without having to select a new color.
This was actually a bit trickier than I thought it would be, I feel like I'm probably missing a more elegant solution, but I couldn't find it.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: