Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use initial color param for favorite color dialog #18039

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Sep 27, 2023

Proposed change

Following #17992, this PR make the code more readable.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@home-assistant home-assistant bot marked this pull request as draft September 27, 2023 12:22
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@piitaya piitaya marked this pull request as ready for review September 27, 2023 14:14
@home-assistant home-assistant bot requested a review from karwosts September 27, 2023 14:14
@piitaya piitaya merged commit b2e260d into dev Sep 27, 2023
8 checks passed
@piitaya piitaya deleted the refactor_light_favorite_initial_color branch September 27, 2023 14:26
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants