Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autocomplete to onboarding, cloud, and password change #14040

Merged
merged 5 commits into from
Oct 10, 2022

Conversation

steverep
Copy link
Member

@steverep steverep commented Oct 7, 2022

Proposed change

Gets the ball rolling on supporting the autocomplete attribute for various text fields:

  • Creates support for it in ha-textfield (not supported by mwc-textfield)
  • Adds it to the text selector
  • Adds it in several locations:
    • Onboarding create user
    • Password change in profile & admin
    • Cloud login & register

Notes

  • I'll work on the auth and MFA flows next - just a bit trickier since the schema comes from core.
  • I did not add it to the add user dialog because that still uses paper-input.
  • This will enable autofill support for anything webkit-based since it supports shadow DOM just fine, but Firefox, Chrome, and extensions that don't support shadow DOM will not work unless the polyfill is added in all other locations. I can look into that.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

@bramkragten bramkragten merged commit a4fcb74 into dev Oct 10, 2022
@bramkragten bramkragten deleted the add-autocomplete-attribute branch October 10, 2022 17:54
@steverep steverep linked an issue Oct 26, 2022 that may be closed by this pull request
3 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Password Managers] Some password manager icons do not show up on input fields
3 participants