Render signal boxes as points with text below #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires a different rendering for polygons as for points, because the polygons need to have their center rendered for the lower zoom levels. The center can only be calculated in the backend, not during rendering in MapLibre GL JS. The center is stored along with the full geometry, such that polygon signal boxes can be rendered as such for high zoom levels. The `signals_signal_boxes` tile source is converted to a function to ensure it can take the zoom level into account to determine which geometry to return to the client. Fixes #133
|
Zoom 10: Zoom 11: Zoom 12: Zoom 13: The signal boxes are better, but there is much to be improved for the signal rendering in zoom levels <16. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires a different rendering for polygons as for points, because the polygons need to have their center rendered for the lower zoom levels.
The center can only be calculated in the backend, not during rendering in MapLibre GL JS.
The center is stored along with the full geometry, such that polygon signal boxes can be rendered as such for high zoom levels.
The
signals_signal_boxestile source is converted to a function to ensure it can take the zoom level into account to determine which geometry to return to the client.Fixes #133