Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signal boxes in buildings aren't rendered properly at levels <11.5 #133

Closed
besentv opened this issue Oct 30, 2024 · 1 comment · Fixed by #138
Closed

Signal boxes in buildings aren't rendered properly at levels <11.5 #133

besentv opened this issue Oct 30, 2024 · 1 comment · Fixed by #138

Comments

@besentv
Copy link

besentv commented Oct 30, 2024

Like the title says, two images as reference:

ORM:
image

ORM-Vector:
image
hiddewie added a commit that referenced this issue Nov 2, 2024
@hiddewie
Render signal boxes as points with text below
725ddb8 
This requires a different rendering for polygons as for points, because the polygons need to have their center rendered for the lower zoom levels.

The center can only be calculated in the backend, not during rendering in MapLibre GL JS.

The center is stored along with the full geometry, such that polygon signal boxes can be rendered as such for high zoom levels.

The `signals_signal_boxes` tile source is converted to a function to ensure it can take the zoom level into account to determine which geometry to return to the client.

Fixes #133
@hiddewie hiddewie mentioned this issue Nov 2, 2024
Merged
@hiddewie
Copy link
Owner

hiddewie commented Nov 2, 2024

Thanks for the issue. A fix will be implemented in #138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Render signal boxes as points with text below hiddewie/OpenRailwayMap-vector
2 participants
@hiddewie @besentv