Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #8
OK, I made great progress today and have a working prototype of a Diagram class along the lines of what you described. I've got three pull requests set up in sequential branches, that I think will help make it a little less overwhelming to review & approve the changes. (I'm going to close the other draft PR as this is the better way to go about it.)
3 is still a work in progress. Currently the diagram only renders the basic data, and is missing some features (for example, it doesn't have showPercentage fully set up yet), but, it DOES work and renders a diagram to the diagramFrame div when
new Diagram()
is called with basic data sets passed as arguments. I figure I can add a few more commits fixing the last few todos in the file, and then pass it off to the other contributor who wanted to work on converting to Typescript. (Maybe he can do some refactoring as well - there is a lot of room for simplification!)