Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagram/setup file structure #17

Merged
merged 6 commits into from
Jan 11, 2022

Conversation

jayeclark
Copy link

@jayeclark jayeclark commented Jan 11, 2022

Partially fixes #8

OK, I made great progress today and have a working prototype of a Diagram class along the lines of what you described. I've got three pull requests set up in sequential branches, that I think will help make it a little less overwhelming to review & approve the changes. (I'm going to close the other draft PR as this is the better way to go about it.)

  1. diagram/setup-file-structure --- literally just copy/pasting files over to a new diagram folder where I'll be working and consolidating functions. I've done it this way because the goal is to have Diagram wholly separate from the website and exportable to the npm registry or as minified js.
  2. diagram/create-diagram-service --- (I will raise this PR after the first is merged) more copy/pasting, creating a js file that only contains diagram-related functions
  3. diagram/refactor-to-class --- (I will raise this PR after 2 is merged) this one contains the most relevant changes. (The first two PRs basically exist just to minimize the code changes that need to be reviewed in the 3rd PR and future PRs on the diagram class.)

3 is still a work in progress. Currently the diagram only renders the basic data, and is missing some features (for example, it doesn't have showPercentage fully set up yet), but, it DOES work and renders a diagram to the diagramFrame div when new Diagram() is called with basic data sets passed as arguments. I figure I can add a few more commits fixing the last few todos in the file, and then pass it off to the other contributor who wanted to work on converting to Typescript. (Maybe he can do some refactoring as well - there is a lot of room for simplification!)

@jayeclark jayeclark mentioned this pull request Jan 11, 2022
Copy link
Owner

@heberleh heberleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a review about the 'service' class

diagram/SetService.js Outdated Show resolved Hide resolved
@heberleh heberleh merged commit c70dc37 into heberleh:dev Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants